Update industrial_ci action version in CI workflow#3734
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3734 +/- ##
=========================================
+ Coverage 0 46.28% +46.28%
=========================================
Files 0 726 +726
Lines 0 59496 +59496
Branches 0 7625 +7625
=========================================
+ Hits 0 27531 +27531
- Misses 0 31798 +31798
- Partials 0 167 +167 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@nbbrooks Fixed issue that caused ci-rolling-* tests to fail. |
There was a problem hiding this comment.
Seems like all that was needed for builds was ros-industrial/industrial_ci#928 - nice work!
| - id: ici | ||
| name: Run industrial_ci | ||
| uses: ros-industrial/industrial_ci@ba2a3d0f830f8051b356711a8df2fedfc5d256cf | ||
| uses: ros-industrial/industrial_ci@c553397753252d630e88e7e91aa69c6c8a478ee0 |
There was a problem hiding this comment.
The named commit sha refers to the master branch. So, why not using it directly?
| uses: ros-industrial/industrial_ci@c553397753252d630e88e7e91aa69c6c8a478ee0 | |
| uses: ros-industrial/industrial_ci@master |
Note that industrial_ci just froze ROS Rolling on Noble to the latest supported index. |
|
So this industrial ci change was a sort of "opt in" to rolling on resolute, but our configuration is still using the frozen noble version?
|
|
Yes, currently industrial_ci still uses Ubuntu Noble (and it's frozen Rolling index) when specifying ROS Rolling w/o a ubuntu release: To switch to the latest Rolling release on Ubuntu Resolute, one needs to specify the Ubuntu release via the environment variable |
3 participants
Description
Please explain the changes you made, including a reference to the related issue if applicable
Checklist